[PATCH] glx: remove unused systemTimeExtension

Emil Velikov emil.l.velikov at gmail.com
Thu Aug 3 18:42:20 UTC 2017


On 29 September 2016 at 18:36, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> Not even a single DRI2/DRISW driver in mesa ever used this. Appears to be a
> dri1 artefact copy/pasted in the dri2/drisw codebase.
>
> Signed-off-by: Emil Velikov <emil.l.velikov at gmail.com>
> ---
>  glx/glxdri2.c      |  1 -
>  glx/glxdricommon.c | 23 -----------------------
>  glx/glxdricommon.h |  2 --
>  glx/glxdriswrast.c |  1 -
>  4 files changed, 27 deletions(-)
>
> diff --git a/glx/glxdri2.c b/glx/glxdri2.c
> index afaf44e..85700fe 100644
> --- a/glx/glxdri2.c
> +++ b/glx/glxdri2.c
> @@ -773,7 +773,6 @@ static const __DRIuseInvalidateExtension dri2UseInvalidate = {
>  };
>
>  static const __DRIextension *loader_extensions[] = {
> -    &systemTimeExtension.base,
>      &loaderExtension.base,
>      &dri2UseInvalidate.base,
>      NULL
> diff --git a/glx/glxdricommon.c b/glx/glxdricommon.c
> index 62cce13..43987d6 100644
> --- a/glx/glxdricommon.c
> +++ b/glx/glxdricommon.c
> @@ -41,29 +41,6 @@
>  #include "glxscreens.h"
>  #include "glxdricommon.h"
>
> -static int
> -getUST(int64_t * ust)
> -{
> -    struct timeval tv;
> -
> -    if (ust == NULL)
> -        return -EFAULT;
> -
> -    if (gettimeofday(&tv, NULL) == 0) {
> -        ust[0] = (tv.tv_sec * 1000000) + tv.tv_usec;
> -        return 0;
> -    }
> -    else {
> -        return -errno;
> -    }
> -}
> -
> -const __DRIsystemTimeExtension systemTimeExtension = {
> -    {__DRI_SYSTEM_TIME, 1},
> -    getUST,
> -    NULL,
> -};
> -
>  #define __ATTRIB(attrib, field) \
>      { attrib, offsetof(__GLXconfig, field) }
>
> diff --git a/glx/glxdricommon.h b/glx/glxdricommon.h
> index f4fcf00..f568918 100644
> --- a/glx/glxdricommon.h
> +++ b/glx/glxdricommon.h
> @@ -36,8 +36,6 @@ __GLXconfig *glxConvertConfigs(const __DRIcoreExtension * core,
>                                 const __DRIconfig ** configs,
>                                 unsigned int drawableType);
>
> -extern const __DRIsystemTimeExtension systemTimeExtension;
> -
>  void *glxProbeDriver(const char *name,
>                       void **coreExt, const char *coreName, int coreVersion,
>                       void **renderExt, const char *renderName,
> diff --git a/glx/glxdriswrast.c b/glx/glxdriswrast.c
> index be32527..69484a5 100644
> --- a/glx/glxdriswrast.c
> +++ b/glx/glxdriswrast.c
> @@ -366,7 +366,6 @@ static const __DRIswrastLoaderExtension swrastLoaderExtension = {
>  };
>
>  static const __DRIextension *loader_extensions[] = {
> -    &systemTimeExtension.base,
>      &swrastLoaderExtension.base,
>      NULL
>  };
> --
Humble ping anyone?

I ended "writing" exact same patch just the other day.

Thanks
Emil


More information about the xorg-devel mailing list