[PATCH xserver] meson: Fix epoll detection

Peter Harris pharris at opentext.com
Fri Aug 11 15:44:25 UTC 2017


On 2017-08-11 5:50 AM, Peter Hutterer wrote:
> On Tue, Aug 08, 2017 at 11:16:13AM -0400, Peter Harris wrote:
>> The epoll code depends on epoll_create1, not epoll_create.
>>
>> The trinary " ? 1 : false" is used because HAVE_EPOLL_CREATE1 is tested
>> with #if instead of #ifdef.
> 
> might be worth using conf_data.set10(...) then? that should write out 0/1
> correctly.

".set10" writes 1 or 0, whereas "? 1 : false" writes 1 or #undef, which
more closely matches what autoconf does.

I'm fine with .set10 if you don't mind a little divergence. Or I could
change #if HAVE_EPOLL_CREATE1 to #ifdef HAVE_EPOLL_CREATE1 to match
(most of) the rest of the server instead, if you prefer.

Peter Harris
-- 
               Open Text Connectivity Solutions Group
Peter Harris                    http://connectivity.opentext.com/
Research and Development        Phone: +1 905 762 6001
pharris at opentext.com            Toll Free: 1 877 359 4866


More information about the xorg-devel mailing list