[PATCH] glx: do not pick sRGB config for 32-bit RGBA visual

[Tapani Pälli]

On 12/20/2017 10:32 PM, Adam Jackson wrote:
> On Mon, 2017-12-11 at 07:53 +0200, Tapani Pälli wrote:
>> Hi;
>>
>> Any comments? Without this change there will be issues with certain
>> Linux desktops when distributions start to use Mesa 17.4.
> 
> I've merged Thomas' GLX visual setup changes to the 1.19 branch since
> at least fdobz#102086 has a positive confirmation of the fix and I'm
> already late in delivering 1.19.6. This change could still be correct
> but I didn't have much success in reproducing the issue to begin with;
> maybe I just don't know what I'm looking for.
> 

When reproduced, the issue is very visible, there are 2 symptoms:

1. Some elements like panel, and searchbox on top are too dark. This 
actually matches very close if not the same as symptoms described in 
102806, although I haven't seen those on other compositors than kwin

2. Some windows are not visible at all, one easy example is any of the 
firefox menus but then there's also a glx testcase attached to bug 103699

These can be reproduced with i965 driver, I haven't tested if such 
issues happen with other drivers that expose sRGB visuals.

Thanks;

// Tapani