[PATCH xserver] dmx: fix linking

Michel Dänzer michel at daenzer.net
Fri Feb 3 01:08:03 UTC 2017


On 03/02/17 06:57 AM, Mihail Konev wrote:
> Regressed-in: bb9128fd ("present: disable page flip")
> Signed-off-by: Mihail Konev <k.mvc at ya.ru>
> ---
> Maybe there should be #ifdef-s instead - I only bisected :)
> 
>  randr/Makefile.am | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/randr/Makefile.am b/randr/Makefile.am
> index 90dc9ec9aac4..90aa1289f958 100644
> --- a/randr/Makefile.am
> +++ b/randr/Makefile.am
> @@ -30,3 +30,4 @@ if XINERAMA
>  librandr_la_SOURCES += ${XINERAMA_SRCS}
>  endif
>  
> +librandr_la_LIBADD = $(top_builddir)/render/librender.la
> 

This looks weird. bb9128fd added a RRHasScanoutPixmap call in present
code; I'd expect that to require linking randr to wherever the present
code ends up, not sure why it would require linking render to randr.

Anyway, https://patchwork.freedesktop.org/patch/136239/ and
https://patchwork.freedesktop.org/patch/136238/ basically undo bb9128fd,
can you test that the DMX failure is fixed with those?


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer


More information about the xorg-devel mailing list