[PATCH xserver] composite: Explicitly validate source picture in compNewPixmap

[Michel Dänzer]

On 03/02/17 12:28 PM, Michel Dänzer wrote:
>  
> @@ -579,6 +580,14 @@ compNewPixmap(WindowPtr pWin, int x, int y, int w, int h)
>                                                 serverClient, &error);
>  
>          if (pSrcPicture && pDstPicture) {
> +            /*
> +             * Validating the source picture may trigger
> +             * compWindowUpdateAutomatic for redirected siblings of this
> +             * window. Within CompositePicture, damageComposite unwraps
> +             * the damage layer before this happens. Validate the source
> +             * here to make sure damage is reported correctly.
> +             */
> +            miCompositeSourceValidate(pSrcPicture);
>              CompositePicture(PictOpSrc,
>                               pSrcPicture,
>                               NULL,

Maybe this should be handled in damageComposite instead, to avoid the
same problem in other cases where a window is used as a source picture?


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer