[PATCH xserver v2] damage: Validate source pictures bound to windows before unwrapping

Adam Jackson ajax at nwnk.net
Wed Feb 8 18:06:16 UTC 2017


On Tue, 2017-02-07 at 11:57 -0500, Alex Deucher wrote:
> On Tue, Feb 7, 2017 at 3:38 AM, Michel Dänzer <michel at daenzer.net>
> wrote:
> > From: Michel Dänzer <michel.daenzer at amd.com>
> > 
> > The lower layers also do this, but no damage may be reported there,
> > since we unwrap before calling down.
> > 
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99220
> > Signed-off-by: Michel Dänzer <michel.daenzer at amd.com>
> 
> Makes sense to me.
> Reviewed-by: Alex Deucher <alexander.deucher at amd.com>

Mmm. I might like the original patch better, I think I'd rather have
composite be aware of how damage works than damage be aware of every
possible way a caller might abuse it. So I reserve the right to flip
this back the other way at some point in the future, if we ever get
around to dix-level damage.

But this does work, and I do give preference to patches that other
people review instead of things I have to review as the last resort,
so, merged:

remote: I: patch #137290 updated using rev 38696ea56854e055c31bd2730adfc7c39aa115b0.
remote: I: 1 patch(es) updated to state Accepted.
To ssh://git.freedesktop.org/git/xorg/xserver
   1c78bec..38696ea  master -> master

- ajax


More information about the xorg-devel mailing list