[PATCH xserver] xwayland: replace hardcoded function name with __func__ in error msg

Peter Hutterer peter.hutterer at who-t.net
Wed Feb 8 21:56:26 UTC 2017


On Wed, Feb 08, 2017 at 02:46:16AM -0500, Olivier Fourdan wrote:
> Hey Peter,
> 
> > > LGTM - Yo get rid of two \n along the way, but I think there were not
> > > needed in the first place so:
> > 
> > oops. no, they're neeed so I added them back (and also to the instance where
> > it was missing). thanks
> 
> Are they really needed? I looked at ErrorF() in the source tree and there
> are plenty of cases where there is no \n at the end, so I looked at
> LogVMessageVerb() where ErrorF() should end up, and it seemed to me it
> would ad it if missing:
> 
> https://cgit.freedesktop.org/xorg/xserver/tree/os/log.c#n702

ah, true. Convenient and useful to know, thanks :)

Cheers,
   Peter


More information about the xorg-devel mailing list