[PATCH 0/7] ScrnInfoRec cleanup

Aaron Plattner aplattner at nvidia.com
Tue Feb 14 21:39:46 UTC 2017


On 02/14/2017 01:28 PM, Alex Deucher wrote:
> On Tue, Feb 14, 2017 at 3:30 PM, Adam Jackson <ajax at redhat.com> wrote:
>> ScrnInfoRec is xfree86's subclass of ScreenRec. It's... showing its age.
>> Much of it is only relevant to the pre-PCI world where probing the
>> hardware was fraught with uncertainty and configuration overrides were
>> common. This is a first cut at cleaning it up a bit, mostly dropping
>> unused or under-used fields. A few of these changes (noted in the commit
>> messages) will require minor driver fixes; I'll be happy to do those
>> before merging the series.
>>
>> One big change I'd like to follow this with is removing fixed dotclock
>> support, on the way to unifying the pre- and post-RANDR-1.2 setup paths.
>> As far as I can tell this would only affect a few ancient mach64, trident,
>> or chips (ahem) chips. Quite possibly all of them are already unsupported
>> because they're not PCI.
>
> Series is:
> Reviewed-by: Alex Deucher <alexander.deucher at amd.com>

Also
Reviewed-by: Aaron Plattner <aplattner at nvidia.com>

 > The sis driver does inspect this
 > member, but hilariously does so only so it can print the same
 > information as the core does.

Hilarious.

>>
>>  common/xf86Config.c    |    1 -
>>  common/xf86Configure.c |    1 -
>>  common/xf86Mode.c      |   26 ++------------------------
>>  common/xf86str.h       |   42 ++++++++----------------------------------
>>  doc/ddxDesign.xml      |   48 ------------------------------------------------
>>  man/xorg.conf.man      |    6 ------
>>  parser/Device.c        |    8 --------
>>  parser/xf86Parser.h    |    1 -
>>  parser/xf86tokens.h    |    1 -
>>  9 files changed, 10 insertions(+), 124 deletions(-)
>>
>> - ajax


More information about the xorg-devel mailing list