[PATCH v7 xserver] tests: fixes for non-enable-xorg build

Pekka Paalanen ppaalanen at gmail.com
Fri Feb 17 10:20:12 UTC 2017


On Tue, 31 Jan 2017 20:16:35 +0500
Mihail Konev <k.mvc at ya.ru> wrote:

> v7: add regressed-by lines

Hi,

current xserver master branch fails for me using:

./configure --disable-docs --disable-devel-docs --enable-xwayland
--disable-{xorg,xvfb,xnest,xquartz,xwin} --enable-debug

xfree86.c:30:18: fatal error: xf86.h: No such file or directory
xi1/protocol-xchangedevicecontrol.c:38:29: fatal error: protocol-common.h: No such file or directory

Bisected: ead5064581665ff40c177dd1b447949f1420e209 is the first bad commit:
	tests: Convert test/ to single binary


This "patch" fixes those failures for me, and 'make check' is happy.

Mihail, could you stick to the standard patch submission, please?
One patch, inline, per one email. No attachments, no weird
multi-patches. Use git-send-email if at all possible.

git-am did successfully consume this v7 email, but I am not sure what
it did. It only generated one commit, with a commit message of the
email body and the first patch only, but apparently squashed all the
patches. I suppose. That's what I tested, but as I'm not sure what it
was, I cannot give a Tested-by for now.

Also, have you kept Patchwork updated? There are quite a lot at:
https://patchwork.freedesktop.org/project/Xorg/patches/?submitter=16444
At least a few sound like they should be marked as superseded.

I'll leave it for the xserver maintainers to say if they want a
re-submission or not.


Thanks,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 801 bytes
Desc: OpenPGP digital signature
URL: <https://lists.x.org/archives/xorg-devel/attachments/20170217/c5d792f4/attachment-0001.sig>


More information about the xorg-devel mailing list