[PATCH RFC xserver] os: Add a mutex to protect io buffers

Keith Packard keithp at keithp.com
Wed Feb 22 23:20:07 UTC 2017


Adam Jackson <ajax at nwnk.net> writes:

> On Wed, 2017-02-22 at 16:50 +0100, Olivier Fourdan wrote:
>> WriteToClient() can be called from XIChangeDeviceProperty() so from the
>> InputThread which is a problem as it allocates and free the input and
>> output buffers.

That seems like a bug to me; the input thread isn't supposed to be
directly interacting with clients. Instead, it should queue a suitable
work proc and have the events delivered from there. This will ensure
proper serialization with request processing so that the right serial
numbers and other data are inserted.

-- 
-keith
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <https://lists.x.org/archives/xorg-devel/attachments/20170222/31394ff6/attachment.sig>


More information about the xorg-devel mailing list