[PATCH xserver] glamor: Declare "pos" in glamor_dash.c

Adam Jackson ajax at nwnk.net
Thu Feb 23 18:59:02 UTC 2017


On Thu, 2017-02-23 at 13:28 +0000, Eric Engestrom wrote:

> I looked a bit more into this, and while I don't know much about glamor
> (or glsl, to be honest), I don't think this fix is correct.
> 
> Was `pos` in glamor_program.c intended to be `gl_Position`, by any
> chance?  That would make more sense to me.

I pushed essentially this version of the patch (pos not gl_Position),
having not read far enough down in the mailbox to see this version.
(And, Dieter's right, picking on the little shit really is
counterproductive for one-liners.)

That said, gl_Position is probably right. But I think dashing is broken
already, so at least now we're just rendering wrong instead of
crashing. If someone wants to get rendering correct too, please do...

- ajax


More information about the xorg-devel mailing list