[RFC xserver] os: log a bug whenever WriteToClient is called from the input thread

walter harms wharms at bfs.de
Thu Feb 23 19:03:23 UTC 2017



Am 23.02.2017 17:16, schrieb Olivier Fourdan:
> Hi,
> 
>>> +extern inline int
>>> +in_input_thread(void);
>>> +
>>
>> maybe i am old fashion but this should be done with input.h, should it ?
> 
> No, I don't think this is possible (in the middle of a stable release) nor even suitable, it's not a new API intended for drivers to use, it's purely internal to the Xserver to tell if it's safe to send data to clients (i.e. if we are on the main thread and not in the input thread)
> 
> Cheers,
> Olivier.


What is about a comment like
/*
	INTERNAL USE ONLY
*/

Otherwise someone else will notice the prototype in input.h

re,
 wh


More information about the xorg-devel mailing list