[PATCH xserver] tests: shuffle around the linking order to please GNU ld

Mihail Konev k.mvc at ya.ru
Wed Jan 25 04:28:21 UTC 2017


On Mon, Jan 23, 2017 at 07:15:46PM +0200, Martin Peres wrote:
> Classic GNU ld resolves symbol dependencies only forward, while GOLD
> seems to work regardless of the specified library order.
> 
> I assume that the original author of the changes (just like me), has
> been using GNU ld with GOLD enabled (default on ArchLinux), and did
> not check on older distros like Ubuntu 16.04 which shows the issue.
> 
> Suggested-by: Eero Tamminen <eero.t.tamminen at intel.com>
> Signed-off-by: Martin Peres <martin.peres at linux.intel.com>
> ---
>  test/Makefile.am | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 

Should be another libxservertest.la_LIBADD -> tests_LDADD breakage.
(The static library was acting like ld's --begin-group ... --end-group
for all its LIBADD-s).

Reviewed-by: Mihail Konev <k.mvc at ya.ru>


More information about the xorg-devel mailing list