[PATCH] xinit: check for correct fork error code

Alan Coopersmith alan.coopersmith at oracle.com
Tue Jan 31 02:20:25 UTC 2017


On 01/30/17 12:35 PM, Tobias Stoeckmann wrote:
> Even though this code is only active on __sun machines, the fork return
> value should be checked for -1, not 1, to detect an error situation.
> ---
>  xinit.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xinit.c b/xinit.c
> index 1b04911..f826b7a 100644
> --- a/xinit.c
> +++ b/xinit.c
> @@ -638,7 +638,7 @@ shutdown(void)
>              Fatal("Unable to run program \"%s\"", "kbd_mode");
>              break;
>
> -        case 1:
> +        case -1:
>              Error("fork failed");
>              break;

Oops!  Thanks for finding & fixing this mistake in the patch I applied out
of our downstream branch, and thanks to whot for pushing it already.

-- 
	-Alan Coopersmith-              alan.coopersmith at oracle.com
	 Oracle Solaris Engineering - http://blogs.oracle.com/alanc


More information about the xorg-devel mailing list