[PATCH libpciaccess] linux: support 32 bit PCI domains

Adam Jackson ajax at nwnk.net
Wed Jul 12 20:39:53 UTC 2017


On Wed, 2017-07-12 at 19:30 +0200, Mark Kettenis wrote:
> > Date: Tue, 11 Jul 2017 10:32:19 -0700
> > From: Stephen Hemminger <stephen at networkplumber.org>
> > 
> > Yes, binary compatibility is a problem. Putting additional data at end
> > of structure is possible, but as was raised in the thread, this won't work
> > if some code puts the structure on the stack.
> > 
> > An alternative (like pci-utils) would be to have a sacrificial element.
> > BSD PCI code would also have to change to do this.
> 
> As explained in the thread, this is still an ABI break.  There is not
> much point in making these changes if you have to bump the shared
> library major anyway.

As far as xserver is concerned, it's not an ABI break. We never embed a
struct pci_device in any ABI types, only pointers to them, and they're
always allocated by the library anyway so anyone sensitive to this
change would already be doing something wrong.

- ajax


More information about the xorg-devel mailing list