[PATCH xserver 3/4] glamor: Drop glamor_set_screen_pixmap().

Eric Anholt eric at anholt.net
Thu Jun 1 22:13:55 UTC 2017

Keith Packard <keithp at keithp.com> writes:

> [ Unknown signature status ]
> Eric Anholt <eric at anholt.net> writes:
>> All that was left here was updating the FBO's size.  However, the FBO
>> size was always set correctly already through
>> glamor_set_pixmap_texture() from whoever had attached a new BO to the
>> pixmap.
> I remember desperately needing this code at some point; do you have any
> idea what has changed which makes that no longer true?
> The key path to understand is when the screen is resized; I think
> server start up is at least easier to validate. My brain is starting to
> hurt from tracing this by hand

Basically I traced that we were currently calling set_pixmap_texture()
and decided that that was complicated enough to prove.  I'm betting that
my various other glamoregl cleanups happened to make this be true (there
are more cleanups in the pipeline, too)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <https://lists.x.org/archives/xorg-devel/attachments/20170601/664e2946/attachment.sig>

More information about the xorg-devel mailing list