[PATCH xserver 2/4] dri1: DRI1 clients are VT clients

Keith Packard keithp at keithp.com
Thu Jun 29 17:21:35 UTC 2017

Adam Jackson <ajax at redhat.com> writes:

> Signed-off-by: Adam Jackson <ajax at redhat.com>

I don't remember much about DRI1, but looking at the code, I'm not
seeing how this manages to suspend DRI1 clients who are in the middle of
rendering something? Are they supposed to be regularly calling GetDrawableInfo?

> @@ -521,6 +522,9 @@ ProcXF86DRIDispatch(register ClientPtr client)
>  {
>      REQUEST(xReq);
> +    if (!xf86VTOwner())
> +        return xf86SetAndSleepVTClient(client);
> +

Might move this after the client->local check so you don't suspend
clients just asking for the version of the extension.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <https://lists.x.org/archives/xorg-devel/attachments/20170629/77d25f1a/attachment.sig>

More information about the xorg-devel mailing list