[PATCH xserver 1/2] Revert "glamor: Remove the FBO cache."

Max Staudt mstaudt at suse.de
Fri Mar 3 16:36:17 UTC 2017

On 03/03/2017 09:46 AM, Michel Dänzer wrote:
> This reverts commit 950ffb8d6fd1480f305e38c571bda44f247f1de2 (and parts
> of commit 4b5326aeba539249fcded91bf7806a708eeca651).

Oh no.

Glamor's BO cache was horribly broken, and I tried to fix it before:


It was then decided to drop it altogether.

The thing is, at least on the Raspberry Pi (vc4) we get 3 BO caches:
 - kernel
 - Mesa

That's quite a lot of memory kept around "just in case".

If you insist on bringing it back, please have a thorough look at my old
There was a lot of broken, as well as dead (!) code that I had to fix
to make this workable on VC4. If we reintroduce a FBO cache, at least
let's do it right this time.


More information about the xorg-devel mailing list