[RFC PATCH xserver v3] xwayland: Monitor client states to destroy callbacks

Michel Dänzer michel at daenzer.net
Wed Mar 8 09:50:45 UTC 2017

On 08/03/17 06:32 PM, Olivier Fourdan wrote:
> Client resources can survive the client itself, in which case we
> may end up in our sync callback trying to access client's data after
> it's been freed/reclaimed.
> Add a ClientStateCallback handler to monitor the client state changes
> and clear the sync callback set up by the glamor drm code if any.
> Signed-off-by: Olivier Fourdan <ofourdan at redhat.com>
> ---
>  v2: [facepalm] forgot to use the state->callback
>  v3: - Rename xwlGlamorPrivateKey as xwl_auth_state_private_key getting
>        rid of camelCase along the way (c'mon, this is xwayland in 2017)
>      - Remove test for clientGone in the sync callback and add a comment
>        as to why this is not needed anymore
>      - Fix GNOME-style-coding space between parenthesis
>      - Register private key before the callback in xwl_glamor_init() so
>        that we don't need to delete the callback if the register fails.

Reviewed-by: Michel Dänzer <michel.daenzer at amd.com>

Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer

More information about the xorg-devel mailing list