[PATCH xrandr] xrandr: suppress misleading indentation warning

Adam Jackson ajax at nwnk.net
Fri Mar 24 15:11:50 UTC 2017

On Wed, 2017-01-18 at 08:52 +0100, Giuseppe Bilotta wrote:
> When printing out rotations, we print a space before any item other than
> the first, and set `first = False` in each block where we print.
> However, this is done in the same line as the conditional that checks if
> first is set, which may give the impression that the assignment is also
> under the conditional. This is not the case, and recent GCC warns about
> this.
> Move the assignment to after we print the value we want to print, which
> (1) doesn't mislead about the indentation, and
> (2) makes logical sense as the _next_ entry is what won't be the first.

Merged this and the --dpi documentation patch, thanks!

remote: I: patch #133793 updated using rev 85e95db7120da3bdaf9efb3033be5f9338e6c328.
remote: I: patch #133794 updated using rev 215a01f1513f918e7295a8a477d4674f7b8085f0.
remote: I: 2 patch(es) updated to state Accepted.
To ssh://git.freedesktop.org/git/xorg/app/xrandr
   1b561d2..215a01f  master -> master

- ajax

More information about the xorg-devel mailing list