[PATCH xserver] xfree86: Remove driver entity hooks and private

Adam Jackson ajax at redhat.com
Wed Mar 29 15:15:55 UTC 2017

On Tue, 2017-03-28 at 12:48 -0700, Eric Anholt wrote:
> > Adam Jackson <ajax at redhat.com> writes:
> > No driver is using these, as far as I know.
> If we're going to leave the args in place for xf86ConfigPciEntity, could
> we assert that init/enter/leave are NULL, to catch if a driver *did*
> exist that used them?

We sure could, let's do that. I didn't take them out because I didn't
feel like fixing up literally every driver just for this. One of these
days we'll have a less boilerplatey driver model...

> The docs for xf86ConfigPciEntity() should probably also note that
> enter/init/leave are unused.  The docs for xf86ConfigIsaEntity(), on the
> other hand, should probably be deleted :)

Will do.

- ajax

More information about the xorg-devel mailing list