[PATCH xserver 5/7] meson: Make XV optional

Jon Turney jon.turney at dronecode.org.uk
Tue May 9 12:21:07 UTC 2017


On 08/05/2017 18:13, Eric Anholt wrote:
> Jon Turney <jon.turney-GrJqePx9RPPAJUdA+FbntA at public.gmane.org> writes:
>
>> Signed-off-by: Jon Turney <jon.turney-GrJqePx9RPPAJUdA+FbntA at public.gmane.org>
>> ---
>>  meson.build       | 11 ++++++++++-
>>  meson_options.txt |  3 +++
>>  2 files changed, 13 insertions(+), 1 deletion(-)
>>
>> diff --git a/meson.build b/meson.build
>> index c7c9c79c3..5f30b996c 100644
>> --- a/meson.build
>> +++ b/meson.build
>> @@ -251,6 +251,16 @@ if libdrm_dep.found()
>>    build_modesetting = dependency('libdrm', version: '>= 2.4.46', required: false).found()
>>  endif
>>
>> +build_xv = false
>> +if get_option('xv') == 'auto'
>> +    if (host_machine.system() != 'windows' and
>> +        host_machine.system() != 'cygwin')
>> +        build_xv = true
>> +    endif
>> +else
>> +    build_xv = get_option('xv') == 'yes'
>> +endif
>
> Optional XV seems a bit silly to me.  Could we just do something
> like:
>
> build_xv = build_xorg || build_dmx || build_ephyr?

I'm all for reducing the number of configuration options :)

I think I'll just drop this patch.



More information about the xorg-devel mailing list