[RFC PATCH xserver] xfree86: build a shared lib identical to Xorg

Eric Anholt eric at anholt.net
Tue May 9 17:58:55 UTC 2017

Peter Hutterer <peter.hutterer at who-t.net> writes:

> Because we can use a shared lib in dlsym() for the symbol loader test, but we
> can't use the executable.
> Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>

Apparently I've had the test working just because my default amd64 build
is PIE, such that the Xorg binary is effectively just a shared lib with
a main.

We may find this lib useful for some of our unit testing, anyway, so I'm
happy with your solution.

> +# For symbol presence testing only
> +xorgserver_lib = shared_library(
> +    'xorgserver',
> +    srcs_xorg,
> +    include_directories: [inc, xorg_inc],
> +    link_whole: xorg_link,
> +    dependencies: xorg_deps,
> +    link_args: '-Wl,--export-dynamic',
> +    c_args: xorg_c_args,
> +    install: false,
> +)
> +
> +xorgserver_dep = declare_dependency(link_with : xorgserver_lib)

Elsewhere we have no ' ' before ':'.

Other than that,

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <https://lists.x.org/archives/xorg-devel/attachments/20170509/a5e923e0/attachment.sig>

More information about the xorg-devel mailing list