[PATCH xserver 3/8] xwayland: Stop printing the EGL version

Olivier Fourdan ofourdan at redhat.com
Mon Nov 6 08:29:06 UTC 2017


Hi Adam,

> It doesn't matter, none of this matters.

It's an indication that Xwayland has started and is using glamor though.

Maybe we could replace it with some message indicating Xwayland has started, could be useful for the Wayland compositors who launch Xwayland on demand? (even that's debatable, weston for example logs a "Spawned Xwayland server, pid ..." when starting Xwayland anyway)

> Signed-off-by: Adam Jackson <ajax at redhat.com>

Acked-by: Olivier Fourdan <ofourdan at redhat.com>

> ---
>  hw/xwayland/xwayland-glamor.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/hw/xwayland/xwayland-glamor.c b/hw/xwayland/xwayland-glamor.c
> index 260e4e0d8..8ffb40d6f 100644
> --- a/hw/xwayland/xwayland-glamor.c
> +++ b/hw/xwayland/xwayland-glamor.c
> @@ -269,7 +269,6 @@ static void
>  xwl_drm_init_egl(struct xwl_screen *xwl_screen)
>  {
>      EGLint major, minor;
> -    const char *version;
>      static const EGLint config_attribs_core[] = {
>          EGL_CONTEXT_OPENGL_PROFILE_MASK_KHR,
>          EGL_CONTEXT_OPENGL_CORE_PROFILE_BIT_KHR,
> @@ -305,9 +304,6 @@ xwl_drm_init_egl(struct xwl_screen *xwl_screen)
>  
>      eglBindAPI(EGL_OPENGL_API);
>  
> -    version = eglQueryString(xwl_screen->egl_display, EGL_VERSION);
> -    ErrorF("glamor: EGL version %s:\n", version);
> -
>      xwl_screen->egl_context = eglCreateContext(xwl_screen->egl_display,
>                                                 NULL, EGL_NO_CONTEXT,
>                                                 config_attribs_core);
>      if (!xwl_screen->egl_context)
> --
> 2.14.3
> 
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: https://lists.x.org/mailman/listinfo/xorg-devel


More information about the xorg-devel mailing list