[PATCH xserver] meson: Get more xkb configuration from xkbcomp.pc

Daniel Stone daniel at fooishbar.org
Mon Nov 6 18:27:09 UTC 2017


Hi,

On 6 November 2017 at 17:56, Adam Jackson <ajax at redhat.com> wrote:
>  xkb_output_dir = get_option('xkb_output_dir')
>  if xkb_output_dir == ''
> -    xkb_output_dir = join_paths(get_option('prefix'), 'share/X11/xkb/compiled')
> +    xkb_output_dir = join_paths(xkb_dir, 'compiled')
>  endif

This should really come under localstatedir, since that's what it is
rather than constant data.

But hey, that wasn't your doing in the first place, so with or without
a fix there, both this and the xkbcomp bindir patch are:
Reviewed-by: Daniel Stone <daniels at collabora.com>

Cheers,
Dnaiel


More information about the xorg-devel mailing list