[PATCH xserver 2/3] ramdac: Add xf86CursorPriv.h to ABI

Hans de Goede hdegoede at redhat.com
Wed Nov 8 10:26:25 UTC 2017


Hi,

On 08-11-17 05:15, Alex Goins wrote:
> https://lists.x.org/archives/xorg-devel/2016-September/050973.html implies that
> xf86CursorScreenPtr is part of the ABI. Mark xf86CursorPriv.h as such.

I'm not sure if exporting this is a good idea. I assume you are just
after xf86CursorScreenPtr->SWCursor ?  If so it is probably a better
idea to add a helper function taking pScreen which gets that and add
that function to the ABI.

Regards,

Hans



> 
> Signed-off-by: Alex Goins <agoins at nvidia.com>
> ---
>   hw/xfree86/ramdac/Makefile.am | 4 ++--
>   hw/xfree86/sdksyms.sh         | 1 +
>   2 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/xfree86/ramdac/Makefile.am b/hw/xfree86/ramdac/Makefile.am
> index 59e0996..89aab61 100644
> --- a/hw/xfree86/ramdac/Makefile.am
> +++ b/hw/xfree86/ramdac/Makefile.am
> @@ -3,9 +3,9 @@ noinst_LTLIBRARIES = libramdac.la
>   libramdac_la_SOURCES = xf86RamDac.c xf86RamDacCmap.c \
>                          xf86CursorRD.c xf86HWCurs.c IBM.c BT.c TI.c
>   
> -sdk_HEADERS = BT.h IBM.h TI.h xf86Cursor.h xf86RamDac.h
> +sdk_HEADERS = BT.h IBM.h TI.h xf86Cursor.h xf86CursorPriv.h xf86RamDac.h
>   
> -EXTRA_DIST = BTPriv.h IBMPriv.h TIPriv.h xf86CursorPriv.h xf86RamDacPriv.h \
> +EXTRA_DIST = BTPriv.h IBMPriv.h TIPriv.h xf86RamDacPriv.h \
>   	CURSOR.NOTES
>   
>   AM_CFLAGS = $(DIX_CFLAGS) $(XORG_CFLAGS)
> diff --git a/hw/xfree86/sdksyms.sh b/hw/xfree86/sdksyms.sh
> index 9aa1eec..56e3fab 100755
> --- a/hw/xfree86/sdksyms.sh
> +++ b/hw/xfree86/sdksyms.sh
> @@ -147,6 +147,7 @@ cat > sdksyms.c << EOF
>   #include "IBM.h"
>   #include "TI.h"
>   #include "xf86Cursor.h"
> +#include "xf86CursorPriv.h"
>   #include "xf86RamDac.h"
>   
>   
> 


More information about the xorg-devel mailing list