[PATCH xserver 3/4] animcur: Run the timer from the device, not the screen

[Keith Packard]

Adam Jackson <ajax at redhat.com> writes:

> +    /*
> +     * Not a simple Unwrap/Wrap as this isn't called along the DisplayCursor
> +     * wrapper chain.
> +     */
> +    pScreen->DisplayCursor = as->DisplayCursor;
> +    (void) (*pScreen->DisplayCursor) (dev, pScreen, ac->elts[elt].pCursor);
> +    as->DisplayCursor = pScreen->DisplayCursor;
> +    pScreen->DisplayCursor = DisplayCursor;

I'm probably reading this out of context, but if this isn't called along
the usual DisplayCursor wrapper chain, then it's presumptuous to smash
in our DisplayCursor pointer; shouldn't it preserve the previous value
and restore that instead?

-- 
-keith
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <https://lists.x.org/archives/xorg-devel/attachments/20171112/baaa2298/attachment.sig>