Re[2]: [PATCH xserver] xfree86/common: Fix VT leave lockup #103782

Алексей Шилин rootlexx at mail.ru
Mon Nov 20 20:07:58 UTC 2017


>Понедельник, 20 ноября 2017, 11:06 +03:00 от Michal Srb <msrb at suse.com>:
>
>If you unlock it in xf86VTLeave, you will get a double unlock in xf86VTEnter.

Argh. You're absolutely right, thanks!

I'll resend the updated version (which locks the input mutex again at the beginning
of xf86VTEnter) so that the incorrect one is not accidentaly picked up by someone.

>Few days ago I sent alternative fix for this bug:
>  Subject: [PATCH] os/inputthread: Force unlock when stopping thread.

Your fix looks better, indeed.

>  It did not get a response so far.

Looks like you forgot to add sign-off tag, which seems to be a requirement per
https://www.x.org/wiki/Development/Documentation/SubmittingPatches/


-- 
Алексей Шилин


More information about the xorg-devel mailing list