[PATCH mga] Fix mga_device_attributes of mgag200eH3.

Mathieu Larouche mathieu.larouche at matrox.com
Wed Oct 18 12:05:58 UTC 2017


On 16/10/2017 3:07 AM, Michal Srb wrote:
> It was missing value for HAL_chipset. All the following values got shifted by one and so the whole record was garbage.
> ---
>
> Alternatively HAL_chipset could be dropped from everywhere because it does not seem to be used.
>
>   src/mga_driver.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/mga_driver.c b/src/mga_driver.c
> index e496d0b..ab93c71 100644
> --- a/src/mga_driver.c
> +++ b/src/mga_driver.c
> @@ -426,7 +426,7 @@ static const struct mga_device_attributes attribs[] = {
>   	16384, 0x4000,          /* Memory probe size & offset values */
>       },
>   
> -    [17] = { 0, 1, 0, 0, 1, 0, 0, new_BARs,
> +    [17] = { 0, 1, 0, 0, 1, 0, 0, 0, new_BARs,
>               (TRANSC_SOLID_FILL | TWO_PASS_COLOR_EXPAND | USE_LINEAR_EXPANSION),
>   	{
>   	    { 50000, 230000 }, /* System VCO frequencies */
This is correct, there's an error there. Thank you for your finding and 
I'm still wondering how it went through. In addition, we could get rid 
of HAL_chipset since there's no plan to bring it back.

Mathieu


More information about the xorg-devel mailing list