[PATCH xserver] present: Only send PresentCompleteNotify events to the presenting client

Keith Packard keithp at keithp.com
Fri Oct 20 19:58:38 UTC 2017


Michel Dänzer <michel at daenzer.net> writes:

> From: Michel Dänzer <michel.daenzer at amd.com>
>
> We were sending the events to all clients listening for them on the
> window. But clients can get confused by events from another client, and
> I can't imagine any case where reciving events from other clients would
> be required.

While I agree that it's unlikely to be useful to send the event to all
listening clients, there is a 'PRESENTEVENTID' in the CompleteNotify
which clients "should" be using to check to see if the event being
delivered is the one associated with their action.

Did we mess up in some client library and not do this? If so, we might
want to fix that library?

I'm *not* saying this isn't a good patch in practice, I just want to
understand whether the system was designed wrong, or if we've
implemented it wrong.

-- 
-keith
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <https://lists.x.org/archives/xorg-devel/attachments/20171020/ae5ef974/attachment.sig>


More information about the xorg-devel mailing list