[PATCH libICE 11/13] add check for mall

Emil Velikov emil.l.velikov at gmail.com
Tue Oct 31 15:18:06 UTC 2017


On 31 October 2017 at 15:15, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> On 18 October 2017 at 17:05, walter harms <wharms at bfs.de> wrote:
>>
>> fix a potential null pointer deference error and
>> properly dispose the affected message
>>
>>  Signed-off-by: Walter Harms <wharms at bfs.de>
>> ---
>>  src/process.c | 27 +++++++++++++++++++++++++++
>>  1 file changed, 27 insertions(+)
>>
> That patch seems ok, but I'm quite weary of it. There are a number of
> subtleties in ICE design I'd like to I'll leave it out ...for now at
> least.
>
... pressed Send a bit too early.

Some of these are due to the EXTRACT.*STRING macros mostly used in process.c.
Those macros have some 'interesting' protocol handling and memory allocation

-Emil


More information about the xorg-devel mailing list