[RFC xserver] present: remove unused argument in present_screen_info::check_flip()

Emil Velikov emil.l.velikov at gmail.com
Mon Sep 4 17:52:36 UTC 2017


From: Emil Velikov <emil.velikov at collabora.com>

Namely: sync_flip has been unused since the code was introduced back in
2015.

Cc: Kenneth Graunke <kenneth at whitecape.org>
Cc: Dave Airlie <airlied at redhat.com>
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
---
Hi all,
I'm fairly certain that the original goal was to actually check the
boolean. Yet I'm not that familiar with the code to be the final
judge of that, hence sending this as an RFC.

Not to mention that this is an ABI break ;-)
---
 hw/xfree86/drivers/modesetting/present.c | 3 +--
 present/present.h                        | 2 +-
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/hw/xfree86/drivers/modesetting/present.c b/hw/xfree86/drivers/modesetting/present.c
index fcff8ee16..a3b138a83 100644
--- a/hw/xfree86/drivers/modesetting/present.c
+++ b/hw/xfree86/drivers/modesetting/present.c
@@ -232,8 +232,7 @@ ms_present_flip_abort(modesettingPtr ms, void *data)
 static Bool
 ms_present_check_flip(RRCrtcPtr crtc,
                       WindowPtr window,
-                      PixmapPtr pixmap,
-                      Bool sync_flip)
+                      PixmapPtr pixmap)
 {
     ScreenPtr screen = window->drawable.pScreen;
     ScrnInfoPtr scrn = xf86ScreenToScrn(screen);
diff --git a/present/present.h b/present/present.h
index aab2e168a..4ff4f00a7 100644
--- a/present/present.h
+++ b/present/present.h
@@ -57,7 +57,7 @@ typedef void (*present_flush_ptr) (WindowPtr window);
 
 /* Check if 'pixmap' is suitable for flipping to 'window'.
  */
-typedef Bool (*present_check_flip_ptr) (RRCrtcPtr crtc, WindowPtr window, PixmapPtr pixmap, Bool sync_flip);
+typedef Bool (*present_check_flip_ptr) (RRCrtcPtr crtc, WindowPtr window, PixmapPtr pixmap);
 
 /* Flip pixmap, return false if it didn't happen.
  *
-- 
2.14.1



More information about the xorg-devel mailing list