[PATCH xserver] fb: Check whether the window is enabled directly

Keith Packard keithp at keithp.com
Tue Sep 12 21:40:45 UTC 2017


Adam Jackson <ajax at redhat.com> writes:

> ... instead of its root window. Xwayland's rootless mode empties the
> root window border clip since its root window has no storage, but
> redirected windows (the only kind it can show) will have a non-empty
> border clip anyway, cf. the #ifdef COMPOSITE in miComputeClips. With
> this change, non-glamor Xwayland's GetImage actually works.
>
> Other acceleration layers may need to change to account for this, but
> this appears to be safe for the existing open source drivers. Only the
> xfree86 DDX has any problem with losing its framebuffer on VT switch,
> and even then only for UMS drivers (which excludes glamor, uxa, and sna
> from consideration). This leaves exa, which already contains code to
> evict pixmaps to host memory on VT switch. Since the xfree86 core will
> still empty the root clip on VT switch, while the root window itself may
> not contain a valid image we won't try to touch it, but GetImage from a
> redirected window will now work even when switched away.
>
> Signed-off-by: Adam Jackson <ajax at redhat.com>

Acked-by: Keith Packard <keithp at keithp.com>

-- 
-keith
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <https://lists.x.org/archives/xorg-devel/attachments/20170912/05ee4a91/attachment.sig>


More information about the xorg-devel mailing list