[PATCH xserver 3/3] meson: Port default warning flags from xorg-macros

Adam Jackson ajax at redhat.com
Wed Sep 27 18:27:54 UTC 2017


On Wed, 2017-09-27 at 18:20 +0100, Daniel Stone wrote:
> Hey,
> 
> On 27 September 2017 at 18:09, Adam Jackson <ajax at redhat.com> wrote:
> > +common_wflags = []
> > +foreach wflag: test_wflags
> > +    if cc.has_argument(wflag)
> > +        common_wflags += [ wflag ]
> > +    endif
> > +endforeach
> > +
> > +add_global_arguments(common_wflags, language : 'c')
> 
> If you're willing to take the dep, this is:
> add_global_arguments(cc.get_supported_arguments(test_wflags), language: 'c')

Neat, didn't know about that one. I just stole the pattern from gtk's
meson.build. Which meson is that new to?

> But the series is:
> Reviewed-by: Daniel Stone <daniels at collabora.com>

Unfortunately I'd reordered this series before I sent it, and not
tested the DMX build with it at all.  c99 requires that it be spelled
__typeof__, you also need -fgnu-keywords or -std=gnu99 to get the test
to work, and to get enough _XOPEN_SOURCE-ish bits set to make
hw/dmx/examples/xinput.c compile. Because clearly asking for C99 and
<string.h> means you don't want strdup.

C is just awful.

Will resend in a moment with some more warning fixes, apologies for the
spam.

- ajax


More information about the xorg-devel mailing list