[PATCH xserver 1/2] modesetting: Don't reuse iterator in nested loop

Walter Harms wharms at bfs.de
Thu Apr 5 14:26:36 UTC 2018



> Daniel Stone <daniel at fooishbar.org> hat am 5. April 2018 um 16:08 geschrieben:
> 
> 
> On 5 April 2018 at 15:06, Walter Harms <wharms at bfs.de> wrote:
> >> Daniel Stone <daniels at collabora.com> hat am 5. April 2018 um 15:58
> >> geschrieben:
> >> -            for (i = 0; i < xf86_config->num_output; i++) {
> >> -                xf86OutputPtr output = xf86_config->output[i];
> >> +            for (j = 0; i < xf86_config->num_output; j++) {
> >> +                xf86OutputPtr output = xf86_config->output[j];
> >
> > Your intention is to loop over J but terminate with i ?
> > that is at least confusing.
> 
> Today really isn't my day. Apologies.


on the positiv side somebody is actualy reading the code .... :)

re,
 wh


More information about the xorg-devel mailing list