[PATCH xserver] dix: always send focus event on grab change

Adam Jackson ajax at redhat.com
Tue Apr 10 18:52:45 UTC 2018


On Tue, 2018-04-10 at 09:14 +1000, Peter Hutterer wrote:
> On Mon, Apr 09, 2018 at 02:35:30PM +0200, Samuel Thibault wrote:
> > Focus events are useless when 'from' and 'to' are the same.  But when
> > this is the result of a (Un)GrabKeyboard request, we should always send
> > them, including when the window manager had previously used XSetInputFocus
> > to specify the focus on a window which happens to be now taking a grab.
> > 
> > This is notably needed for window manager using XI to always get keyboard
> > events even during grabs, so they can determine exactly when grabbing is
> > active.
> > 
> > Signed-off-by: Samuel Thibault <samuel.thibault at ens-lyon.org>
> 
> good catch, thanks.
> Reviewed-by: Peter Hutterer <peter.hutterer at who-t.net>
> 
> Ajax - feel free to take this one or wait for 1.20.1. It should be safe but
> there could be subtle bugs. Proably not any worse than having this broken
> for the last 10 years.

Merged, thanks:

remote: I: patch #215922 updated using rev c67f2eac56518163981af59f5accb7c79bc00f6a.
remote: I: 1 patch(es) updated to state Accepted.
To ssh://git.freedesktop.org/git/xorg/xserver
   14be894b3f..c67f2eac56  master -> master

- ajax


More information about the xorg-devel mailing list