[PATCH xserver] modesetting: Fix inverted check in dri2 WaitMSC

Adam Jackson ajax at redhat.com
Mon Apr 16 18:08:27 UTC 2018


ms_queue_vblank() returns false on failure.

Reported-by: Chris Wilson <chris at chris-wilson.co.uk>
Signed-off-by: Adam Jackson <ajax at redhat.com>
---
 hw/xfree86/drivers/modesetting/dri2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/xfree86/drivers/modesetting/dri2.c b/hw/xfree86/drivers/modesetting/dri2.c
index fd36aa118..96eaaaaf7 100644
--- a/hw/xfree86/drivers/modesetting/dri2.c
+++ b/hw/xfree86/drivers/modesetting/dri2.c
@@ -749,7 +749,7 @@ ms_dri2_schedule_wait_msc(ClientPtr client, DrawablePtr draw, CARD64 target_msc,
             target_msc = current_msc;
 
         ret = ms_queue_vblank(crtc, MS_QUEUE_ABSOLUTE, target_msc, &queued_msc, seq);
-        if (ret) {
+        if (!ret) {
             static int limit = 5;
             if (limit) {
                 xf86DrvMsg(scrn->scrnIndex, X_WARNING,
-- 
2.16.2



More information about the xorg-devel mailing list