[PATCH xserver v2] xwayland: avoid using freed xwl_window on unrealize

Olivier Fourdan fourdan at gmail.com
Thu Apr 19 07:15:41 UTC 2018


Hi Roman,

On 18 April 2018 at 20:34, Roman Gilg <subdiff at gmail.com> wrote:

>
> I believe this check should be ORed with xwl_window->window == window.
> Otherwise in case the top parent window is unrealized first,
> xwl_window->present_window != window holds here and afterwards
> xwl_present_cleanup won't be called again since the xwl_window is
> already gone. I.e. an existing frame callback wouldn't be destroyed in
> this case.
>

Sure, I've sent a new patch to do that, but I reckon this can wait after
the release, we might leak a frame callback in some cases (although
valgrind did not really complain yet), but we won't crash anymore.

Cheers,
Olivier
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.x.org/archives/xorg-devel/attachments/20180419/f59575f2/attachment.html>


More information about the xorg-devel mailing list