[PATCH v2] meson: add option to disable selective werror

Eric Anholt eric at anholt.net
Fri Aug 10 01:59:10 UTC 2018


Matt Turner <mattst88 at gmail.com> writes:

> On Thu, Aug 9, 2018 at 1:03 PM, Eric Anholt <eric at anholt.net> wrote:
>> "Marty E. Plummer" <hanetzer at startmail.com> writes:
>>
>>> Signed-off-by: Marty E. Plummer <hanetzer at startmail.com>
>>
>> We definitely want our -W flags.  Are you finding that one of the
>> -Werror ones is throwing errors for you?  If so, let's fix that for
>> everyone.
>
> -Werror is fine for developers, but for distros it's a huge pain.
>
> https://flameeyes.blog/2009/02/25/future-proof-your-code-dont-use-werror/
>
> With every new version of GCC, not only does the set of warnings on by
> default change but also its ability to detect warnings (i.e., the same
> -Wflag is now more effective). Upgrading GCC already causes lots of
> churn, and having to immediately deal with -Werror fall out just makes
> this more difficult.

I also happen to hate Werror, and I think the solution is to delete it
from meson.build for everyone, not introduce a flag to get the right
behavior.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <https://lists.x.org/archives/xorg-devel/attachments/20180809/bfe5268b/attachment.sig>


More information about the xorg-devel mailing list