[PATCH xserver 3/7] randr: Support "non-desktop" property

[Michel Dänzer]

On 2018-02-28 05:27 PM, Adam Jackson wrote:
> On Wed, 2018-02-28 at 16:35 +0100, Michel Dänzer wrote:
>> On 2018-02-12 10:51 PM, Keith Packard wrote:
>>> Tracks changes to the non-desktop property so that when non-zero,
>>> outputs will always appear to be disconnected.
>>>
>>> Signed-off-by: Keith Packard <keithp at keithp.com>
>>> Reviewed-by: Adam Jackson <ajax at nwnk.net>
>>
>> [...]
>>
>>> @@ -442,6 +465,7 @@ ProcRRGetOutputInfo(ClientPtr client)
>>>          .crtc = output->crtc ? output->crtc->id : None,
>>>          .mmWidth = output->mmWidth,
>>>          .mmHeight = output->mmHeight,
>>> +        .connection = output->nonDesktop ? RR_Disconnected : output->connection,
>>>          .connection = output->connection,
>>
>> BTW, I don't think this was intended to leave the existing connection
>> initializer line, clobbering the new one?
> 
> ... huh. That's not what's in the tree:
> 
> desoxy:~/git/xserver% git grep -A1 connection.*nonDesktop
> randr/rroutput.c:        .connection = output->nonDesktop ? RR_Disconnected : output->connection,
> randr/rroutput.c-        .subpixelOrder = output->subpixelOrder
> --
> randr/rroutput.c:            .connection = output->nonDesktop ? RR_Disconnected : output->connection,
> randr/rroutput.c-            .subpixelOrder = output->subpixelOrder,
> desoxy:~/git/xserver% git describe                       
> xorg-server-1.19.0-641-g85ff1cdbd

Yeah, the duplicate line was removed by e4e3447603b5 ("Add RandR leases
with modesetting driver support [v6]"). So it's harmless, except
possibly when bisecting. I stumbled over it when reporting the GPU
screen crash.


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer