[PATCH xserver 00/10] Implement RandR 1.6 (leases and non-desktop)

[Keith Packard]

Adam Jackson <ajax at nwnk.net> writes:

> 4 and 6 are:
>
> Reviewed-by: Adam Jackson <ajax at redhat.com>
>
> 3 and 8 would have my r-b too once the review feedback is addressed. 9
> and 10 I think we can expect new versions of anyway, it sounded on IRC
> like you'd found some bugs.

I've marked the reviewed bugs and merged fixes for the bugs found by
your suggested 'xlease' hack:

   v5: Terminate all leases on server reset.
    
    	Leases hang around after the associated client exits so that
    	the client doesn't need to occupy an X server client slot and
    	consume a file descriptor once it has gotten the output
    	resources necessary.
    
    	Any leases still hanging around when the X server resets or
    	shuts down need to be cleaned up by calling the kernel to
    	terminate the lease and freeing any DIX structures.
    
    	Note that we cannot simply use the existing
    	drmmode_terminate_lease function on each lease as that wants
    	to also reset the video mode, and during server shut down that
    
       modesetting: Validate leases on VT enter
    
    	The kernel doesn't allow any master ioctls to run when another
    	VT is active, including simple things like listing the active
    	leases. To deal with that, we check the list of leases
    	whenever the X server VT is activated.
    
       xfree86: hide disabled cursors when resetting after lease termination
    
    	The lessee may well have played with cursors and left one
    	active on our screen. Just tell the kernel to turn it off.

> For the actual 1.6 enablement I've been using this for a merged
> protocol repo:
>
> https://cgit.freedesktop.org/~ajax/xorgproto

That's awesome. It sounds like we should do a release of that (pre RandR
1.6) right away, and then a release of that with RandR 1.6 merged. Shall
I just go do that? We're not breaking anything that distros are using as
the old packages will hang around.

-- 
-keith
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <https://lists.x.org/archives/xorg-devel/attachments/20180124/6c9680d0/attachment.sig>