[PATCH] Xephyr: Prefer using MIT-SHM FD-passing when possible

Keith Packard keithp at keithp.com
Tue Jan 30 21:55:49 UTC 2018


Alexander Volkov <a.volkov at rusbitech.ru> writes:

This code should be fine, but it's hard to review because all of the old
code has been moved around. Ideally, you'd create a pair of patches, the
first of which does the major code motion of the old code without
changing any functionality, and then a second patch which adds the fd
passing bits. If you think you can manage that, I can review it more
quickly.

> +#if (XCB_SHM_MAJOR_VERSION == 1 && XCB_SHM_MINOR_VERSION >= 2) || XCB_SHM_MAJOR_VERSION > 1

I'd be fine with just requiring a newer version of the XCB bits instead
of having these extra #if bits.

-- 
-keith
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <https://lists.x.org/archives/xorg-devel/attachments/20180130/a7752874/attachment.sig>


More information about the xorg-devel mailing list