[PATCH app/fonttosfnt 3/5] Remove shadowing rc variable

Alan Coopersmith alan.coopersmith at oracle.com
Tue Jul 31 03:02:16 UTC 2018


On 07/30/18 06:53 PM, Peter Hutterer wrote:
> All code paths assign rc and heck it immedately after. We can re-use the one

"heck it immedately" -> "check it immediately"

> from the outer loop.
> 
> Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
> ---
>   read.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/read.c b/read.c
> index bee518c..98522b5 100644
> --- a/read.c
> +++ b/read.c
> @@ -107,7 +107,7 @@ readFile(char *filename, FontPtr font)
>       if(font->numNames == 0 && face->style_name && face->family_name) {
>           char *full_name, *unique_name;
>           BDF_PropertyRec prop;
> -        int rc, i;
> +        int i;
>           if(strcmp(face->style_name, "Regular") == 0)
>               full_name = sprintf_alloc("%s", face->family_name);
>           else
> 

Reviewed-by: Alan Coopersmith <alan.coopersmith at oracle.com>

-- 
	-Alan Coopersmith-               alan.coopersmith at oracle.com
	 Oracle Solaris Engineering - https://blogs.oracle.com/alanc


More information about the xorg-devel mailing list