[PATCH] Improve the ButtonInfo description.

Peter Hutterer peter.hutterer at who-t.net
Fri Jun 8 00:59:03 UTC 2018


On Thu, Jun 07, 2018 at 03:32:08AM +0200, Roman Kapl wrote:
> It failed to mention it is followed by a bit-mask and then the atoms.
> 
> Signed-off-by: Roman Kapl <code at rkapl.cz>
> ---
>  include/X11/extensions/XI2proto.h | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

Patch content is correct, thanks. But what repository did you make this
patch to?  This should go into the inputproto repo but it has the XI2proto.h
in the root tree.

Cheers,
   Peter

> 
> diff --git a/include/X11/extensions/XI2proto.h b/include/X11/extensions/XI2proto.h
> index 4cdaa0d..28a9062 100644
> --- a/include/X11/extensions/XI2proto.h
> +++ b/include/X11/extensions/XI2proto.h
> @@ -149,8 +149,9 @@ typedef struct {
>  
>  /**
>   * Denotes button capability on a device.
> - * Struct is followed by num_buttons * Atom that names the buttons in the
> - * device-native setup (i.e. ignoring button mappings).
> + * Struct is followed by a button bit-mask (padded to four byte chunks) and
> + * then num_buttons * Atom that names the buttons in the device-native setup
> + * (i.e.  ignoring button mappings).
>   */
>  typedef struct {
>      uint16_t    type;           /**< Always ButtonClass */
> -- 
> 2.17.1
> 
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: https://lists.x.org/mailman/listinfo/xorg-devel
> 


More information about the xorg-devel mailing list