[PATCH xserver 1/2] xwayland: simplify xwl_glamor_pixmap_get_wl_buffer()

[Michel Dänzer]

On 2018-06-11 10:22 AM, Olivier Fourdan wrote:
> When retrieving the Wayland buffer from a pixmap, if the buffer already
> exists, the GBM backend will return that existing buffer.
> 
> However, as seen with the Present issues, if the call had previously
> passed a wrong size, that buffer will remain at the wrong size for as
> long as the buffer exists, which is error prone.
> 
> Considering that the width/height passed to get_wl_buffer() is always the
> actual pixmap  drawable size, and considering that the EGLStream backend
> makes no use of the size either, there is really no point in passing the
> width/height around.
> 
> Simplify the xwl_glamor_pixmap_get_wl_buffer() and EGL backends API by
> removing the pixmap size, and use the drawable size instead.
> 
> Signed-off-by: Olivier Fourdan <ofourdan at redhat.com>

Reviewed-by: Michel Dänzer <michel.daenzer at amd.com>

Since the Wayland buffer represents the pixmap, their dimensions must
always match.


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer