[PATCH xserver 0/2] xwayland: couple of EGL backend API cleanup

Emil Velikov emil.l.velikov at gmail.com
Thu Jun 14 17:38:49 UTC 2018


On 11 June 2018 at 09:22, Olivier Fourdan <ofourdan at redhat.com> wrote:
> Hi,
>
> The recent issue with Present due to the wrong pixmap size being given
> to xwl_glamor_pixmap_get_wl_buffer() got me thinking.
>
> Considering that the code always use the drawable size now, that passing
> a wrong size is error prone because once the buffer is created for the
> given pixmap, subsequent calls to xwl_glamor_pixmap_get_wl_buffer() will
> always return that same buffer with GBM backend and considering EGLStream
> has no use for the given size either, there is really no point in passing
> the width/height in the API...
>
> The second patch was suggested by Emil, both GBM and EGLStream backends
> implement init_wl_registry() and has_wl_interfaces() so there is no
> point in marking those as optional.
>
> Those patches go on top and complement the previous series, i.e.:
>
>  https://patchwork.freedesktop.org/series/44302/
>  https://patchwork.freedesktop.org/series/44303/
>  https://patchwork.freedesktop.org/series/44423/
>  https://patchwork.freedesktop.org/series/44489/
>
What's the blocker of pushing these - short on commit access, other?
If the former, that should be addressed. You have done some serious
work on Xwayland.

That said, the series is
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>

-Emil


More information about the xorg-devel mailing list