[PATCH xorgproto 1/2] Remove the use of no-op B16 & B32 bitfield macros in headers

Emil Velikov emil.l.velikov at gmail.com
Tue Jun 19 15:54:26 UTC 2018


On 18 June 2018 at 01:30, Keith Packard <keithp at keithp.com> wrote:
> Alan Coopersmith <alan.coopersmith at oracle.com> writes:
>
>> These have always done nothing on all platforms except CRAY.
>> As https://bugs.freedesktop.org/show_bug.cgi?id=45202 points out
>> we don't even detect when they've been wrong for decades.
>>
>> Performed via:
>> find include -name '*.h' | grep -v md.h | xargs perl -i -p -e 's{\s+B\d+}{}g'
>> followed by manual whitespace fixups to preserve visual alignment.
>>
>> The #defines for B16 & B32 are left in place to preserve compatibility
>> in any code that used them outside the xorgproto repo.
>>

Good call about keeping those. Quick look shows a handful of users:

app/lbxproxy
app/xfs

driver/xf86-video-sis
driver/xf86-video-sisusb
driver/xf86-video-via
driver/xf86-video-vmware

lib/libICE
lib/libICE
lib/liblbxutil
lib/libSM
lib/libX11
lib/libxkbfile

mesa/drm
mesa/mesa - dri1, appledri, windowsdri copies

xserver - same as mesa

>> Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
>
> Acked-by: Keith Packard <keithp at keithp.com>
>

Reviewed-by: Emil Velikov <emil.velikov at collabora.com>

HTH
Emil


More information about the xorg-devel mailing list