Missing swapl() in Xext/saver.c?

Mihai Moldovan ionic at ionic.de
Sat Mar 10 09:31:35 UTC 2018


Hi


In
https://cgit.freedesktop.org/xorg/xserver/commit/?id=9edcae78c46286baff42e74bfe26f6ae4d00fe01
the swapl() call for stuff->suspend was removed. That sounds like a bad idea to me?

xScreenSaverSuspendReq to this day defines it as a Bool, which is typedef'd to
int everywhere and includes the (ignored) B32 width specifier, so using swapl()
on the member sounds like a good idea. Definitely isn't a CARD8 object, despite
its name.



Mihai

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 898 bytes
Desc: OpenPGP digital signature
URL: <https://lists.x.org/archives/xorg-devel/attachments/20180310/1e18262c/attachment.sig>


More information about the xorg-devel mailing list