[PATCH xserver v2 1/4] os: move xf86PrivsElevated here

Nicolai Hähnle nicolai.haehnle at amd.com
Wed Mar 14 14:55:06 UTC 2018


On 14.03.2018 14:36, Emil Velikov wrote:
> On 13 March 2018 at 21:46, Ben Crocker <bcrocker at redhat.com> wrote:
> 
>> --- a/include/os.h
>> +++ b/include/os.h
>> @@ -368,6 +368,9 @@ System(const char *cmdline);
>>   #define Fclose(a) fclose(a)
>>   #endif
>>
>> +extern _X_EXPORT Bool
>> +PrivsElevated(void);
>> +
> Any particular reason why this is exported?
> Is it simply mimicking the surrounding code, or there's a genuine reason for it?

I believe I just mimicked the surrounding code, but it's been a while...

Cheers,
Nicolai

> 
> Not an issue either way, the series is
> Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
> 
> Somewhat unrelated:
> Seems like commit 49f77fff1495c0a2050fb18f9b1fc627839bbfc2 exported
> 1000+ symbols as part of (?) folding the extension modules in core.
> Yet it never followed to hide the internal functions as things were done.
> 
> -Emil
> 



More information about the xorg-devel mailing list