[PATCH xserver 05/12] meson: Build Xorg suid wrapper

Adam Jackson ajax at redhat.com
Tue Mar 27 14:20:35 UTC 2018


On Mon, 2018-03-26 at 18:45 -0600, Keith Packard wrote:
> Adam Jackson <ajax at redhat.com> writes:
> 
> > Signed-off-by: Adam Jackson <ajax at redhat.com>
> > +if get_option('suid_wrapper')
> > +    executable('Xorg.wrap',
> > +        'xorg-wrapper.c',
> > +        include_directories: [inc, xorg_inc],
> > +        dependencies: xorg_deps,
> > +        c_args: xorg_c_args,
> > +        install: true,
> > +        install_dir: get_option('libexecdir'),
> > +        # install_mode: ['r-sr-xr-x', 0, 0],
> 
> I assume your package files fix the permissions? If I'm reading the
> autotools version, there's a chown and chmod for that?

Yes, we just set the thing to be suid. Annoyingly install_mode: works
for the install_data() verb but not for executable(). There's a bug:

https://github.com/mesonbuild/meson/issues/3328

Probably this path should add a warning() to alert the builder?

- ajax


More information about the xorg-devel mailing list